Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hot reloading of interface files #1779

Merged
merged 10 commits into from
Jun 9, 2024
Merged

Enable hot reloading of interface files #1779

merged 10 commits into from
Jun 9, 2024

Conversation

amylizzle
Copy link
Collaborator

Screencast.from.2024-05-12.14-03-37.webm

Adds a new proc to /world ODHotReloadInterface which forces a reload of the cached interface file and notifies all connected clients to reload it.

Note this also cleans up some stuff that would probably causes issues with reconnecting too, so that's a nice bonus.

@boring-cyborg boring-cyborg bot added Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime labels May 12, 2024
@amylizzle amylizzle mentioned this pull request May 12, 2024
Merged
amylizzle
amylizzle commented May 21, 2024
View reviewed changes
Copy link
Collaborator Author

@amylizzle amylizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo + using

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wixoaGit
Copy link
Member

wixoaGit commented Jun 9, 2024

I think it would be better to make this a server-side RT command

wixoaGit
wixoaGit requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@wixoaGit wixoaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter seems to have missed these whitespace issues.

@amylizzle
Copy link
Collaborator Author

I think it would be better to make this a server-side RT command

I think it's actually better to leave this as a DM side action, so it can be easily integrated into existing admin and debug tooling which is pretty much all DM already.

The eventual plan here is to integrate it with hot reloading actions of IDEs, but until that's in place I think this is the best approach.

@wixoaGit
Copy link
Member

wixoaGit commented Jun 9, 2024

I think it would be better to make this a server-side RT command

I think it's actually better to leave this as a DM side action, so it can be easily integrated into existing admin and debug tooling which is pretty much all DM already.

The eventual plan here is to integrate it with hot reloading actions of IDEs, but until that's in place I think this is the best approach.

Can we get an RT command regardless so this can be used on codebases that haven’t added it?

@github-actions github-actions bot added size/L and removed size/M labels Jun 9, 2024
@amylizzle amylizzle requested a review from wixoaGit June 9, 2024 19:09
@wixoaGit wixoaGit merged commit 89f5e6c into OpenDreamProject:master Jun 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amylizzle @wixoaGit